Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Bzlmod-related profiler spans #24762

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 19, 2024

This fills in a few gaps in the timing profile.

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Dec 19, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 19, 2024

@meteorcloudy While not fixing a regression, this could help analyze regressions and is by itself very safe. Would you be okay with cherry-picking this into 8.0.1?

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 10, 2025

@meteorcloudy Friendly ping

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this one, and yes, looks safe I'm fine with it being in 8.0.1 if it makes it.

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 10, 2025
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 10, 2025

@bazel-io fork 8.0.1

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 10, 2025
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 10, 2025
This fills in a few gaps in the timing profile.

Closes bazelbuild#24762.

PiperOrigin-RevId: 714028550
Change-Id: I5772b59c5d3b6d73306ea5d8380169465f348f27
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2025
This fills in a few gaps in the timing profile.

Closes #24762.

PiperOrigin-RevId: 714028550
Change-Id: I5772b59c5d3b6d73306ea5d8380169465f348f27

Commit
edb2b06

Co-authored-by: Fabian Meumertzheim <[email protected]>
fmeum added a commit to fmeum/bazel that referenced this pull request Jan 14, 2025
This fills in a few gaps in the timing profile.

Closes bazelbuild#24762.

PiperOrigin-RevId: 714028550
Change-Id: I5772b59c5d3b6d73306ea5d8380169465f348f27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants